Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Xcode warnings #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
groue merged 1 commit into 3.37.0 from fix-Xcode-warnings
Jan 9, 2022
Merged

Fix Xcode warnings #52

groue merged 1 commit into 3.37.0 from fix-Xcode-warnings
Jan 9, 2022

Conversation

@groue
Copy link
Collaborator

@groue groue commented Dec 10, 2021
edited
Loading

This PR removes as many Xcode warnings as possible:

  • warnings about localization (🤷)
  • warnings about recommended compiler flags

Xcode also warns because IPHONEOS_DEPLOYMENT_TARGET is not iOS 12. Well, warn as much as you want, Xcode: this pull requests does not change the requirements of this repository.

Copy link
Collaborator Author

groue commented Dec 12, 2021

Xcode also warns because IPHONEOS_DEPLOYMENT_TARGET is not iOS 12. Well, warn as much as you want, Xcode: this pull requests does not change the requirements of this repository.

I'm not enough aware of the projects that use swiftlyfalling/SQLiteLib, and how many would break if we would raise IPHONEOS_DEPLOYMENT_TARGET to 12.

So I will eventually decide, on my own, to raise the iOS deployment target of this project. Fighting Xcode and the Apple policy on backward compatibility is not a position that one can hold for long.

I wait for the author and users of this library to chime in and express their eventual rationale against such a bump.

Xcode insists on bumping IPHONEOS_DEPLOYMENT_TARGET, but this is not acceptable for this project which has lower minimum requirements. So there will remain warnings.
@groue groue merged commit a9cc9e5 into 3.37.0 Jan 9, 2022
@groue groue deleted the fix-Xcode-warnings branch January 9, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swiftlyfalling swiftlyfalling Awaiting requested review from swiftlyfalling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /