-
Notifications
You must be signed in to change notification settings - Fork 6k
Factorize addOption/addSwitch method #7814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wing328
merged 2 commits into
swagger-api:master
from
MartinDelille:factorise-add-option-method
Mar 20, 2018
Merged
Factorize addOption/addSwitch method #7814
wing328
merged 2 commits into
swagger-api:master
from
MartinDelille:factorise-add-option-method
Mar 20, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks. It looks good. I probably should have put those methods in DefaultCodegen from the start.
stkrwork
stkrwork
approved these changes
Mar 10, 2018
@jimschubert @stkrwork Little question: when I do a change and I want to test it, is there a quicker command than mvn clean package which runs all the test?
@MartinDelille mvn clean package -DskipTests should skip the tests for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
I find out that the same code was written multiple time so I decided to factorize it in the
DefaultCodegenclass.Ping to all the impacted langage maintainers: @stcarrez @micheleISEP @mandrean @jimschubert @ravinikam @stkrwork @fvarose @etherealjoy