-
Notifications
You must be signed in to change notification settings - Fork 6k
[JAVA] Correct consumes/produces attributes for Spring Controllers #7760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@srsp
srsp
changed the title
(削除) fix #7734: Correct consumes/produces attributes for Spring Controllers (削除ここまで)
(追記) [JAVA] Fix #7734: Correct consumes/produces attributes for Spring Controllers (追記ここまで)
Mar 5, 2018
JFCote
JFCote
approved these changes
Mar 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good to me (see my comment in #7734)
jeff9finger
commented
Mar 7, 2018
👍 LGTM
@srsp thanks for the fix.
Thanks @jeff9finger @JFCote @jmini for reviewing the fix.
@wing328
wing328
changed the title
(削除) [JAVA] Fix #7734: Correct consumes/produces attributes for Spring Controllers (削除ここまで)
(追記) [JAVA] Correct consumes/produces attributes for Spring Controllers (追記ここまで)
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes issue #7734. Basically, the
producesandconsumesattributes from Springs@RequestMappingare omitted if they are not defined in the YAML. Before this fix they were filled withapplication/jsonor""for GET requests, where the latter leads to startup errors in the Spring Application Context.@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger can you review the change?