-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix inconsistency between model name and file name in python client #7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@banh-gao tests (with updated samples) passed via https://travis-ci.org/swagger-api/swagger-codegen/builds/344730950
Next time, please update the Python Petstore samples by running the shell scripts or batch files under ./bin/ or .\bin\windows\
Python petstore samples updated via b4827be
bedge
commented
May 9, 2018
This bug is present in STABLE, 2.3.1:
❯ swagger-codegen version
2.3.1~/git/apis/bindings/bindings/models/init.py in ()
21 from bindings.models.http_endpoint import HTTPEndpoint
22 from bindings.models.map_context_root import MapContextRoot
---> 23 from bindings.models.model_property import ModelProperty
24 from bindings.models.module import Module
25 from bindings.models.node import Node~/git/apis/bindings/bindings/models/model_property.py in ()
16 import six
17
---> 18 from bindings.models.object import Object # noqa: F401,E501
3.0.0 claims no python code generators:
https://github.com/swagger-api/swagger-codegen/releases:
java and inflector are the only supported languages.
Is there a functional tag one can use for python in the interim?
samohant
commented
May 7, 2019
Module not found for 'swagger_client.model.errorunknown' in swagger_client python
Fixes issue #7357 using the same fix as #4958
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes modules filename generation for the python client. Issue reported in #7357 and #4684.
The fix applied to python client generator is the same as the one applied to the Flask server in #4958.