-
Notifications
You must be signed in to change notification settings - Fork 6k
[PHP] Run unit tests on 'tests' directory #7675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Run unit tests on 'tests' directory #7675
Conversation
https://travis-ci.org/swagger-api/swagger-codegen/builds/342288933#L5767
🤔 💦
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (bundle-test) on project PhpPetstoreClientTests: Command execution failed. Cannot run program "vendor/bin/phpunit tests" (in directory "/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/php/SwaggerClient-php"): error=2, No such file or directory -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :PhpPetstoreClientTests
@ackintosh no worry. I'll take a look later this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to do something like the following instead:
<configuration>
<executable>vendor/bin/phpunit</executable>
<arguments>
<argument>tests</argument>
</arguments>
</configuration>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😭 ✨
- Swagger\Client\PetApiTest::testInvalidArgument
Failed asserting that exception of type "\InvalidArgumentException" is thrown.
swagger-codegen/samples/client/petstore/php/SwaggerClient-php/tests/PetApiTest.php
Lines 381 to 385 in 47614bb
hmm...
I think this means that we have a different issue: PetApi::findPetsByStatus() accepts an empty array 😕
PetApi::findPetsByStatus() should throw an exception if an empty array is passed.
Uh oh!
There was an error while loading. Please reload this page.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
By #7200, the
testdirectory is completely cleaned and all the test code is integrated intotests. So we have to run unit tests which in thetestsdirectory.