-
Notifications
You must be signed in to change notification settings - Fork 6k
[Java][Jersey2] Make generated client code thread safe #7605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... the withHttpInfo pattern used by many other generated clients
... the withHttpInfo pattern used by many other generated clients
@jeff9finger
jeff9finger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
@jeff9finger
jeff9finger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tsiq-karold thanks for the PR. Sorry for the delay in merging this PR into master due to Chinese New Year celebration.
@jeff9finger thanks for reviewing the change.
Upgrade Note
The following properties have been removed from ApiClient.java:
- protected int statusCode;
- protected Map<String, List<String>> responseHeaders;
To obtain the status code and HTTP headers, please use the additional WithHttpInfo methods instead.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR is to make the generated Jersey 2 client thread safe. Currently, the only way to get to response headers and status is by inspecting some fields on the ApiClient which is not thread safe. This PR changes the generated code to follow a similar pattern used by other generated clients with "withHttpInfo" flavours of each method. It is backwards compatibility breaking as it removes the existing header and status fields.
Fixes #7453
cc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger