Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PHP] Add generator version #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into swagger-api:master from ackintosh:add-generator-version
Dec 7, 2017

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 7, 2017
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add generator version so that users can easily tell from the files which version of Swagger Codegen was used to generate the code.
ref. ruby

wing328 reacted with thumbs up emoji
- bin/php-petstore.sh
- bin/security/php-petstore.sh
Copy link
Contributor Author

@wing328 wing328 merged commit 1ff3b00 into swagger-api:master Dec 7, 2017
@ackintosh ackintosh deleted the add-generator-version branch December 9, 2017 02:14
Gingonic pushed a commit to wirelane/swagger-codegen that referenced this pull request Dec 9, 2017
* Add generator version
* Update samples
- bin/php-petstore.sh
- bin/security/php-petstore.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /