-
Notifications
You must be signed in to change notification settings - Fork 6k
[Java][RESTEasy] Make efficient use of entrySet iterator. #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wing328
merged 1 commit into
swagger-api:master
from
iamolivinius:feature-efficiant-map-iteration
Dec 7, 2017
Merged
[Java][RESTEasy] Make efficient use of entrySet iterator. #7105
wing328
merged 1 commit into
swagger-api:master
from
iamolivinius:feature-efficiant-map-iteration
Dec 7, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iamolivinius
iamolivinius
force-pushed
the
feature-efficiant-map-iteration
branch
from
December 4, 2017 10:43
6e661e0 to
1aa4602
Compare
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.
Let me know if you need help fixing it.
I added the email address to my gh account.
@iamolivinius looks good now 👍
@wing328
wing328
changed the title
(削除) Make efficient use of entrySet iterator. (削除ここまで)
(追記) [Java][RESTEasy] Make efficient use of entrySet iterator. (追記ここまで)
Dec 7, 2017
Gingonic
pushed a commit
to wirelane/swagger-codegen
that referenced
this pull request
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bbdouglas
@JFCote
@sreeshas
@jfiala
@lukoyanov
@cbornet
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
The original method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.
http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR