Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[JavaScript] Fix for issue #5358: Regression in 2.3 using multi parameters (Cannot read property 'buildCollectionParam' of undefined) #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into swagger-api:2.3.0 from michaelkourlas:issue-5358
Apr 11, 2017

Conversation

@michaelkourlas
Copy link
Contributor

@michaelkourlas michaelkourlas commented Apr 10, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

See #5358.

wing328 reacted with thumbs up emoji
Copy link
Contributor

frol commented Apr 10, 2017

The fix works for me! Thank you!

Copy link
Contributor

frol commented Apr 10, 2017

@michaelkourlas There is "Update tests" commit which doesn't bring or update any tests; is that intended?

Copy link
Contributor Author

michaelkourlas commented Apr 10, 2017 via email

I just regenerated the API libraries for the test -- that's all.
...
On Apr 10, 2017 1:49 PM, "Vlad Frolov" ***@***.***> wrote: @michaelkourlas <https://github.com/michaelkourlas> There is "Update tests" commit which doesn't bring or update any tests; is that intended? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5362 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmExKOQAS_LF3arnEV4HutGsv6lijkGks5rumuZgaJpZM4M5FRl> .

Copy link
Contributor

frol commented Apr 11, 2017

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /