Additional parameters to test additional cases. #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

antihax wants to merge 3 commits into swagger-api:master

from antihax:AdditionalParameters

Open

Additional parameters to test additional cases. #4417

antihax wants to merge 3 commits into swagger-api:master from antihax:AdditionalParameters

Conversation

@antihax

Copy link

Contributor

@antihax antihax commented Dec 17, 2016

PR checklist

Read the contribution guildelines.
[!!!] Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Adds some observed cases that cause compile errors on some clients.

required queryParam of array integers
optional queryParam of array integers
optional bodyParam

This will legitimately break some of the affected clients.

Go failed: PR [Go] Add optional parameters to go client using map[string]interface{} #4415 fixes.
Java feign passed.

antihax added 3 commits

December 16, 2016 20:29

@antihax


 Add additional parameters.

9e79773

 - Required []int64 parameter in queryParams
 - Optional []int64 parameter in queryParams
 - Optional body parameter.

@antihax


 Update all test cases.

65d2411

@antihax


 Remove second gemspec.

9c0fc4a

@wing328

Copy link

Contributor

wing328 commented Dec 20, 2016

@antihax thanks for adding more test cases. I think what I will do is to cherry-pick the 1st commit as not all generators are ready for the new test cases.