-
Notifications
You must be signed in to change notification settings - Fork 6k
[jaxrs] Updated generator to use additional properties instead of system properties #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaxrs] Updated generator to use additional properties instead of system properties #1731
Conversation
properties which are very difficult to set from maven
@evigeant thanks for the PR. The change looks good to me as it replaces system property with additional configuration to make the user experience more consistent.
I'll merge the PR tomorrow.
@wing328 let me get back on this--I need to make sure the calling syntax is either back compatible or very well documented for each client
OK we should merge this. @evigeant could you please rebase?
I will rebase this soon, I'm not home currently
On Dec 30, 2015 11:01 PM, "Tony Tam" notifications@github.com wrote:
OK we should merge this. @evigeant https://github.com/evigeant could
you please rebase?—
Reply to this email directly or view it on GitHub
#1731 (comment)
.
Conflicts: modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JaxRSServerCodegen.java modules/swagger-codegen/src/test/java/io/swagger/codegen/options/JaxRSServerOptionsProvider.java
@wing328 I merged master so that this branch could be merged automatically, however, the Travis CI build failed with an error in the Petstore Clojure client unrelated to what I was fixing.
What should I do now? Should I attempt to fix the clojure error? Or is it random timeout error and I should push a fake commit so that Travis CI builds again?
@evigeant I saw that you've pushed another commit and the CI passed. We'll review and approve this PR shortly. Thanks for the contribution.
Tests look good.
[jaxrs] Updated generator to use additional properties instead of system properties
In the java jaxrs server generation code, Java system properties were used to configure the output folder, the code packages and the implementation output folder.
There are already facilities to configure the output folder and the packages, so these were used instead of the system properties. For the implementation package, the additional properties were used instead of system properties as this seems to be the standard mechanism to pass additional configuration to the generator.
Java system properties are very hard to set from a maven build and this prevented me from confguring the implementation folder correctly from my maven build.