-
Notifications
You must be signed in to change notification settings - Fork 286
React Native Turbo Module Rebase #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AliAkhgar
wants to merge
1
commit into
superpoweredSDK:master
from
AliAkhgar:react_native_turbo_module
Closed
React Native Turbo Module Rebase #805
AliAkhgar
wants to merge
1
commit into
superpoweredSDK:master
from
AliAkhgar:react_native_turbo_module
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @AliAkhgar
Thanks for reaching out to us. Integration with React Native is already possible as it is currently and we are not planning to do support of a complete React Native package as it is not in our main customer base's focus, with all due respect we'll have to reject your request.
Thanks anyways and I hope you still have success integrating Superpowered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As the React Native's new architecture is being widely used, there can be an effort to maintain a unified Superpowered ReactNative package. I've examined the project structure and although it's the same for all platforms, it would be nice if we maintain unified packages for cross platform solutions. I can start with React Native.
There are multiple enhancements and that can be done as phase 1 or this first pull request.
Here's what I have in mind
And ofcourse, as a new phase, we can consider pouring more of the Superpowered into the new library to provide low latency audio or maybe even cryptographic libraries. If there would be possibility to publish the package on npm, it would be great.
Let me know if you are interested, so perhaps we can discuss it more.