Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] #685 Tutorial on Novelets #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NimaSarajpoor wants to merge 3 commits into stumpy-dev:main
base: main
Choose a base branch
Loading
from NimaSarajpoor:Tutorial_Novelets

Conversation

@NimaSarajpoor
Copy link
Collaborator

@NimaSarajpoor NimaSarajpoor commented Oct 14, 2022

This addresses issue #685, Novelet Notebook. I was talking about this paper with one of my friends, and I decided to implement it. And, then I decided to create a notebook and push it here.

I have not reproduced the figures yet. For now, I just tried to provide the gist of paper and implement the algorithm and show the result.

Next steps:

  • Check out MATLAB code to ensure the authors remain faithful to the algo provided in the paper
  • Reproduce figures

Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov-commenter commented Oct 14, 2022
edited
Loading

Codecov Report

Base: 99.60% // Head: 99.60% // No change to project coverage 👍

Coverage data is based on head (8a623e3) compared to base (ac238b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@ Coverage Diff @@
## main #692 +/- ##
=======================================
 Coverage 99.60% 99.60% 
=======================================
 Files 81 81 
 Lines 12758 12758 
=======================================
 Hits 12707 12707 
 Misses 51 51 

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator Author

NimaSarajpoor commented Oct 14, 2022
edited
Loading

@seanlaw
side note: the error raised here might be one of those (easy-to-resolve?) cases that might be resolved by the following:

  • setting config variable STUMPY_STDDEV_THRESHOLD to smaller value: 1e-20
  • refine std calculation if it is less than 1.0 (recall that this can mean not taking advantage of rolling std when we have T = np.random.rand() as std will be definitely less than 1.0

(OR, It might be one of those hard cases where cov becomes very small)

Copy link
Contributor

seanlaw commented Oct 15, 2022

Thanks @NimaSarajpoor. Looks good

NimaSarajpoor reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /