Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migration: Add note about file URLs in SB10 #32815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shilman wants to merge 1 commit into next
base: next
Choose a base branch
Loading
from shilman/add-file-url-migration-note

Conversation

@shilman
Copy link
Member

@shilman shilman commented Oct 23, 2025 •
edited by coderabbitai bot
Loading

Closes N/A

Documented a migration note that was missing when I upgraded Reshaped.

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Added migration guidance showing how to convert resolved file paths to URLs (and back) when updating path resolution, with concrete before/after examples and best practices for configuration updates.

@shilman shilman added documentation ci:docs Run the CI jobs for documentation checks only. labels Oct 23, 2025
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Documentation updated to show how to convert resolved file paths to file URLs during Storybook migration, including before/after examples using import.meta.resolve and fileURLToPath, and an example updating managerEntries to use file URLs.

Changes

Cohort / File(s) Summary
Storybook migration documentation
MIGRATION.md		 Added guidance and concrete examples for converting relative file paths to URLs using import.meta.resolve and fileURLToPath, and for updating managerEntries configuration to use file URLs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shilman/add-file-url-migration-note
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0db34bb and 4dbc457.

📒 Files selected for processing (1)
  • MIGRATION.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • MIGRATION.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b68fa4a and 0db34bb.

📒 Files selected for processing (1)
  • MIGRATION.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Danger JS
  • GitHub Check: Core Unit Tests, windows-latest

Copy link

nx-cloud bot commented Oct 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4dbc457

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025年10月23日 18:22:46 UTC

@shilman shilman added this to the 10 blocking milestone Oct 23, 2025
@shilman shilman force-pushed the shilman/add-file-url-migration-note branch from 0db34bb to 4dbc457 Compare October 23, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Milestone

10 blocking

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /