fix: dont add when helmetdata already has same instance #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

king-of-emotion wants to merge 1 commit into staylor:main

from king-of-emotion:not-add-when-already-has-same-instance

Open

fix: dont add when helmetdata already has same instance #176

king-of-emotion wants to merge 1 commit into staylor:main from king-of-emotion:not-add-when-already-has-same-instance

Conversation

@king-of-emotion

Copy link

@king-of-emotion king-of-emotion commented Jul 11, 2022

I use react-helmet-async like https://github.com/staylor/react-helmet-async#usage-without-context example, but every time I access the website that has Helmet Component, helmetData add same instance and not remove.

Dispatcher class has componentWillUnmount, but it is not called probably because this class render method return null.

So, I want to check the helmetData when add the instance that helmetData already has or not.

sorry for my poor english.


 fix: dont add when helmetdata already has same instance

82c6bbb

@king-of-emotion king-of-emotion force-pushed the not-add-when-already-has-same-instance branch from 7a72ceb to 82c6bbb Compare

July 11, 2022 09:35

@king-of-emotion king-of-emotion changed the title ~~(削除) fix: dont add when helmetdata has already same instance (削除ここまで)~~ (追記) fix: dont add when helmetdata already has same instance (追記ここまで)

Jul 11, 2022

@king-of-emotion

Copy link

Author