-
Notifications
You must be signed in to change notification settings - Fork 286
Create Playwright test harness #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👏
We should include Node18 and use v3 for checkout and setup-node.
For the PR title, I'd prefer imperative present tense, e.g., Create Playwright test harness. That's inline with the commit history and common best practice, see https://365git.tumblr.com/post/3308646748/writing-git-commit-messages
@manekinekko can you look into why the CI is not running on this PR please?
manekinekko
commented
Jun 30, 2022
Thank you @HannahZhuSWE for your contribution. I left a comment to change the workflow setting for the CI to run on every branch and PR.
Thank you Wassim!
@fhinkel I implemented all the suggestions for this PR
Screen Shot 2022年07月06日 at 10 16 00 PM
Thanks @HannahZhuSWE. But I still don't see the test running on this PR.
As discussed, this is not running because the PR is form a fork. I think we can merge this as it's green on your fork.
Uh oh!
There was an error while loading. Please reload this page.
Created a playwright test harness and github action that runs the tests on push and pull requests to the main branch and at midnight. Tests can be run with
npm run playwright_test. Note in order to run playwright a package.json file and start script was created.