Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

App engine #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marickvantuil merged 14 commits into stackkit:master from miccehedin:app-engine
Feb 13, 2024
Merged

App engine #122

marickvantuil merged 14 commits into stackkit:master from miccehedin:app-engine
Feb 13, 2024

Conversation

@miccehedin
Copy link
Contributor

@miccehedin miccehedin commented Oct 9, 2023

This add two things:

1: Use a local credential file for authenticating task submisson (useful for local testing).
2: Option to us App Engine task instead of Http task. This makes the process take place in app engine only, and e.g. the app engine service to handle the task can be specified.

Copy link
Member

Thanks for the PR @miccehedin 👍 I'll get it merged soon. It just needs some test fixing and some extra tests for the AppEngine functionality and then it's good to go!

$this->app->singleton(CloudTasksClient::class, function ($app) {
$config = config('queue.connections.cloudtasks');
$options = [];
if (!empty($config['credential_file'])) {
Copy link
Member

@marickvantuil marickvantuil Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miccehedin This can already be done by setting the GOOGLE_APPLICATION_CREDENTIALS environment. Can I therefore remove this bit?

@marickvantuil marickvantuil added the safe-to-test Pull request has access to workflow secrets to run tests label Jan 29, 2024
@github-actions github-actions bot removed the safe-to-test Pull request has access to workflow secrets to run tests label Jan 30, 2024
@marickvantuil marickvantuil added the safe-to-test Pull request has access to workflow secrets to run tests label Jan 30, 2024
@github-actions github-actions bot removed the safe-to-test Pull request has access to workflow secrets to run tests label Jan 30, 2024
@marickvantuil marickvantuil added the safe-to-test Pull request has access to workflow secrets to run tests label Jan 30, 2024
miccehedin and others added 13 commits February 13, 2024 18:46
@marickvantuil marickvantuil merged commit e5a6cb3 into stackkit:master Feb 13, 2024
Copy link
Member

Thnx @miccehedin, I just tagged v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marickvantuil marickvantuil marickvantuil left review comments

Assignees

No one assigned

Labels

safe-to-test Pull request has access to workflow secrets to run tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /