Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Audience signing fix #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborbencebekesi wants to merge 1 commit into stackkit:master from gaborbencebekesi:audience

Conversation

@gaborbencebekesi
Copy link

@gaborbencebekesi gaborbencebekesi commented Jul 19, 2023

This pull request fixes the following issue.

"From the documentation, the audience should not be a hash. It should be an URL."

#113

petercsete reacted with thumbs up emoji
Copy link
Member

Thanks for the PR! Currently, by leaving the audience null, it will skip checking the audience when a task is processed. This is for apps that don't need this level of security because they have their task handler not publicly accessible like here. I think this PR would break that set up.
May I ask what the problem is? That way I understand it better and can help think of some solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /