-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add optional signed_audience flag #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional signed_audience flag #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable was unused.
Added a second fix as well - task name sanitization failed when the task was a closure. See error below:
Task ID \"Closure (CreateMissingProductsFromErplyAction.php:70)-0b31fdb7-b683-431b-8e90-487020684351-1688131669\" can contain only letters ([A-Za-z]), numbers ([0-9]), hyphens (-), or underscores (_). Task ID must between 1 and 500 characters.",
Uh oh!
There was an error while loading. Please reload this page.
Fix for #113
This fixes issues with some Cloud Run setups where providing the audience to the OidcToken causes the queue runners to receive 401 when trying to POST to Cloud Run instances.