This repository was archived by the owner on Jan 28, 2021. It is now read-only.
-
Couldn't load subscription status.
- Fork 110
Add VIEWs support #858
Merged
erizocosmico
merged 22 commits into
src-d:feature/views
from
agarciamontoro:feature.views
Oct 28, 2019
Merged
Add VIEWs support #858
erizocosmico
merged 22 commits into
src-d:feature/views
from
agarciamontoro:feature.views
Oct 28, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
@agarciamontoro
agarciamontoro
requested a review
from a team
as a code owner
October 25, 2019 10:25
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Trying to make golangcibot happy Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
erizocosmico
erizocosmico
suggested changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah, that was a long read. Good job! Overall it looks really good, just some minor nitpicks to make code more idiomatic and a couple of suggestions and lgtm.
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Before, this function read the string containing all the identifiers *and* the separators between them, splitting the string afterwards to retrieve the list. Now, the list of identifiers is built on the go. Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
@agarciamontoro
agarciamontoro
force-pushed
the
feature.views
branch
from
October 25, 2019 13:33
ccdbd17 to
3fee47c
Compare
We can discard the error if it was thrown because the view does not exist. But we don't know if the Delete function will throw different errors in the future, so it is safer to discard only the one we are sure about. Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
erizocosmico
erizocosmico
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that create view statement can be only executed by users with write permissions.
@erizocosmico
erizocosmico
changed the base branch from
master
to
feature/views
October 25, 2019 15:05
I've changed the base of the PR to feature/views branch. All the views PRs will be merged there and then feature/views to master to avoid having partial functionality in master.
@agarciamontoro the follow up PRs should be made against that branch.
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Make sure that create view statement can be only executed by users with write permissions.
Done in a006ec7
ajnavarro
ajnavarro
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds basic support for VIEWs. In particular:
CREATE [OR REPLACE} [db_name.]view_name AS select_exprI wanted to publish this PR as it is because it was getting too big, but the following tasks are still pending for a future PR:
Fixes #53.