This repository was archived by the owner on Jan 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
sql: finish root span of the query #854
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
But there are formatting modifications that are duplicated in #851. Maybe we should merge that PR and rebase this one over master afterwards.
EDIT: Oh, and Travis is failing.
@agarciamontoro yup. But it's only whitespace changes after all, so doesn't matter much. Some commit might have gone to master without gofmt
@erizocosmico
erizocosmico
force-pushed
the
fix/root-span-finish
branch
from
October 22, 2019 15:05
4d61955 to
f067013
Compare
Rebased
Fixes src-d#853 Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
erizocosmico
force-pushed
the
fix/root-span-finish
branch
from
October 22, 2019 15:10
f067013 to
b6ada0e
Compare
agarciamontoro
agarciamontoro
approved these changes
Oct 22, 2019
ajnavarro
ajnavarro
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CI pass
CI is failing because of a random C# issue that happens from time to time downloading and setting up dotnet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853