Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

sql/index/pilosa: better error messages #841

Merged

Conversation

@erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Oct 14, 2019

Related to src-d/gitbase#971

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico added the enhancement New feature or request label Oct 14, 2019
@erizocosmico erizocosmico requested a review from a team October 14, 2019 09:34
Copy link
Contributor

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor Author

Shall we merge this @ajnavarro?

Copy link
Contributor

juanjux commented Oct 15, 2019

@erizocosmico, you're co-maintainer so AFAIK you can already merge.

Copy link
Contributor Author

Oh, yes, you're right.

@erizocosmico erizocosmico merged commit b5a2318 into src-d:master Oct 15, 2019
@erizocosmico erizocosmico deleted the feature/better-errors-pilosa-driver branch October 15, 2019 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@carlosms carlosms carlosms approved these changes

@agarciamontoro agarciamontoro agarciamontoro approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /