This repository was archived by the owner on Jan 28, 2021. It is now read-only.
-
Couldn't load subscription status.
- Fork 110
Fix integer literals parsing #840
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8754654
Modify convertInt so it returns the smallest representation allowed
agarciamontoro 09e535d
Add a rule to convert integer literals in INSERT
agarciamontoro 25ce62f
Test the new rule to convert integers in INSERT nodes
agarciamontoro be23624
Modify getInt64Literal to try to convert smaller representations
agarciamontoro 506c515
Convert literals to specific int64 values in GROUP BY parsing
agarciamontoro 463c5e4
Modify ROUND and YEARWEEK functions to manage all integer types
agarciamontoro 244439c
Adapt all tests to new integer parsing
agarciamontoro 5616382
Add missing cases to pilosa decodeGob and compare functions
agarciamontoro 95124bb
Add smaller integer types to the conversion to sqltypes.Value
agarciamontoro 2395078
Fix formatting of convertInt. HT @erizocosmico
agarciamontoro daf82c5
Run gofmt over the whole codebase
agarciamontoro f38b019
Move integer conversion from ad-hoc rule to Insert.Execute
agarciamontoro dcf2612
Test missing cases in ROUND function
agarciamontoro 2233b4d
Refactor type tests to cover all missing cases
agarciamontoro d436a96
Add missing cases to pilosa decodeGob test
agarciamontoro c0899fb
Test parsing of integer literals
agarciamontoro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -207,4 +207,3 @@ func TestCreateIndex(t *testing.T) { | |
| require.NoError(os.RemoveAll(tmpDir)) | ||
| }() | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.