This repository was archived by the owner on Jan 28, 2021. It is now read-only.
-
Couldn't load subscription status.
- Fork 110
Implemented UPDATE #832
Merged
Merged
Implemented UPDATE #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Hydrocharged #831 merged! you can rebase when you wish. Thanks!
@Hydrocharged
Hydrocharged
force-pushed
the
updates
branch
3 times, most recently
from
October 1, 2019 19:16
2b1e5f7 to
fbdd9bf
Compare
@ajnavarro It has been rebased!
@Hydrocharged
Hydrocharged
changed the title
(削除) Implemented UPDATE and properly fail on invalid ORDER BY columns (削除ここまで)
(追記) Implemented UPDATE (追記ここまで)
Oct 1, 2019
erizocosmico
erizocosmico
approved these changes
Oct 15, 2019
ajnavarro
ajnavarro
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CI pass. It should pass just rebasing against master.
Sorry for the delay on this one, @Hydrocharged. When rebasing, build will fail because of #835. You would probably just need to pass a *sql.Context wherever it is needed.
Signed-off-by: Daylon Wilkins <daylon@liquidata.co>
Signed-off-by: Daylon Wilkins <daylon@liquidata.co>
@Hydrocharged
Hydrocharged
force-pushed
the
updates
branch
from
October 16, 2019 17:56
fbdd9bf to
e847998
Compare
The *sql.Contexts have been passed around! 😄
agarciamontoro
agarciamontoro
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
Thank you for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Notice: one of the tests will fail until #831 is merged in, as it is required to fix one of the bugs that that test catches.
This is an implementation of UPDATE, which brings with it a new interface. Unlike the other interfaces, this one supplies two rows, the original row, and the updated row. This decision was made so that implementations that rely on primary keys can have access to the old primary key if need be.
(削除) Besides the big change, I've also caught a bug where supplying a non-existent column to ORDER BY will cause the query to still succeed, while ignoring the ORDER BY clause. Testing against MySQL showed that an error is the proper behavior, and this has been corrected. Since the change was small, I added it here rather than making an entirely-new PR for it. (削除ここまで)This was fixed by #818.