This repository was archived by the owner on Sep 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 534
Fix an edge case when fetching remotes with unrelated incomplete history. Fixes #1151 #1152
Open
NonLogicalDev
wants to merge
1
commit into
src-d:master
from
NonLogicalDev:fix/fetch-unrelated-remotes
Open
Fix an edge case when fetching remotes with unrelated incomplete history. Fixes #1151 #1152
NonLogicalDev
wants to merge
1
commit into
src-d:master
from
NonLogicalDev:fix/fetch-unrelated-remotes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@NonLogicalDev
NonLogicalDev
force-pushed
the
fix/fetch-unrelated-remotes
branch
2 times, most recently
from
May 17, 2019 01:20
8c61d43 to
77f216e
Compare
...Fixes src-d#1151 In getHaves, allow the getHavesRef to fail with Object Not found when iterating over incomplete history, and don't treat it as a fatal error. Signed-off-by: Oleg Utkin <oleg.utkin@nonlogical.io>
@NonLogicalDev
NonLogicalDev
force-pushed
the
fix/fetch-unrelated-remotes
branch
from
May 17, 2019 17:34
77f216e to
8570a78
Compare
How behaves git?
It does not error out when attempting to fetch on a shallowly cloned repository. Just checked:
git init
git remote add repo1 <url1>
git fetch repo1 --depth 1
git remote add repo2 <url2>
git fetch repo2 --depth 1 // this works in git, but equivalent fails in `go-git`
In the same situation go-git catches an error object not found when enumerating wants
@mcuadros Any update on this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In getHaves, allow the getHavesRef to fail with
object not foundwheniterating over incomplete history, and don't treat it as a fatal error.
It might also worth to revise the
object.NewCommitPreorderIterlogic,to perhaps not fail once reachable commits are exhausted.
Fixes #1151