-
Notifications
You must be signed in to change notification settings - Fork 8
Abandon test suite for loops for pytest best practices
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kurtmckee
kurtmckee
force-pushed
the
use-parameters-not-for-loops
branch
from
July 30, 2024 14:02
61f35ab to
02a681f
Compare
Rebased on main to (ideally) resolve the CI failures caused by the past ruff error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forloops in the test suite have significant disadvantages. Among them: a single failing test input causes the entire test to fail, rather than failing the specific input combinations that can cause failure.While pytest output can help identify the specific failure inputs in the
forloop, the best practice is to use pytest.mark.parametrize; this allows pytest to handle each parameter independently.This PR swaps out
forloops in the test suite with pytest'spytest.mark.parametrizedecorator.