-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Align JWT Testing Documentation #17951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align JWT Testing Documentation #17951
Conversation
Signed-off-by: Houssam El Mansouri <elmansouri.houssam@gmail.com>
848da13 to
53573ab
Compare
@jzheaux can you have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Chu3laMan, thanks for looking to improve the docs!
I'm not yet sure what you are wanting to achieve here, and maybe you can help me. The docs you added are duplicates of paragraphs that follow in both sections. Also, since JWT is covered first, phrases like "Similar to opaque token" can be confusing since it hasn't yet been covered.
Can you tell me more what you are wanting to get out of the rearrangement and then I'm happy to help get the docs to that point with you?
Uh oh!
There was an error while loading. Please reload this page.
Description
Updates the "Testing JWT Authentication" sections in both servlet and webflux documentation to match the consistent structure and style used by other OAuth 2.0 testing sections.
Changes
Title updates: Changed section titles from "Testing JWT Authentication" to "Testing OAuth 2.0 Resource Servers with JWT"
Added controller examples: Shows when SecurityMockMvcRequestPostProcessors#jwt() and SecurityMockServerConfigurers#mockJwt() are necessary (when controllers expect @AuthenticationPrincipal Jwt)
Improved introductions: Added consistent motivation paragraphs similar to other OAuth 2.0 sections
Enhanced clarity: Better explains the specific use case for JWT testing helpers
Fixes: #10028