-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Replace deprecated #check calls with #authorize #16965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ec2047 to
fbc98a2
Compare
...rc/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java
Show resolved
Hide resolved
Hey @evgeniycheban , It would be nice if the verify method of the AuthorizationManager interface also call authorize.
Hey @evgeniycheban , It would be nice if the
verifymethod of theAuthorizationManagerinterface also call authorize.
Yeah, good catch, I must have missed that one.
fbc98a2 to
5b2fbea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @evgeniycheban! I've left some feedback inline.
...st/java/org/springframework/security/authorization/ObservationAuthorizationManagerTests.java
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java
Show resolved
Hide resolved
Closes spring-projectsgh-16936 Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
5b2fbea to
863e016
Compare
Hi, @jzheaux I've updated the PR.
It would be nice to make the same improvement for ReactiveAuthorizationManager as a separate commit.
Hi, @jzheaux @franticticktick I've added a new commit replacing check calls with authorize for ReactiveAuthorizationManager.
a191f9f to
8f2a6aa
Compare
...thorize Closes spring-projectsgh-16936 Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
8f2a6aa to
1172581
Compare
Thanks again, @evgeniycheban, also @franticticktick for your feedback. This is now merged into main.
Closes gh-16936