Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Avoid wiping non-writable fields in nested objects when modifying a persistent object using PUT #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@vierbergenlars
Copy link
Contributor

@vierbergenlars vierbergenlars commented Aug 26, 2022

Because #mergeForPut() fetches the PersistentEntity based on the
class of target, we can't pass Optional<> as source or target, as
that would lead to nested objects (e.g. JPA @Embeddable) are not
considered as persistent entities.

That leads to properties of that are @JsonIgnored or @JsonProperty(access = READ_ONLY) to
be null'ed, because the freshly deserialized source object is used
directly, and those properties are never written to by jackson.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

tgeens, rschev, dgradecak, thijslemmens, and paulcwarren reacted with thumbs up emoji 
Because `#mergeForPut()` fetches the `PersistentEntity` based on the
class of `target`, we can't pass `Optional<>` as source or target, as
that would lead to nested objects (e.g. JPA `@Embeddable`) are not
considered as persistent entities.
That leads to properties of that are `@JsonIgnored` or `@JsonProperty(access = READ_ONLY)` to
be null'ed, because the freshly deserialized source object is used
directly, and those properties are never written to by jackson.
@vierbergenlars vierbergenlars changed the title (削除) Unwrap Optional for nested entities when merging objects (削除ここまで) (追記) Avoid wiping non-writable fields in nested objects when modifying a persistent object using PUT (追記ここまで) Nov 17, 2022
@odrotbohm odrotbohm self-assigned this Feb 20, 2023
odrotbohm added a commit that referenced this pull request Feb 21, 2023 
This is needed to consider read-only properties within those objects as those would otherwise get overridden.
Fixes: #2174
odrotbohm added a commit that referenced this pull request Feb 21, 2023 
This is needed to consider read-only properties within those objects as those would otherwise get overridden.
Fixes: #2174
@odrotbohm odrotbohm added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 21, 2023
odrotbohm added a commit that referenced this pull request Jun 12, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
odrotbohm added a commit that referenced this pull request Jun 12, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
odrotbohm added a commit that referenced this pull request Jun 12, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
odrotbohm added a commit that referenced this pull request Jun 12, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
odrotbohm added a commit that referenced this pull request Jun 13, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
odrotbohm added a commit that referenced this pull request Jun 13, 2023 
The fix for #2174 introduced a bug for our PUT handling of nested documents in case the target object's field value is null as it would only apply the nested value if all Optionals were present. This is, of course not the case.
Fixes #2264.
Copy link

mjustin commented Jun 28, 2023 •
edited
Loading

I believe this change had the side-effect of causing fields named "id" in directly nested objects in MongoDB documents to no longer update when a PUT request is issued (see #2280 for details).

I noticed this as a new failure that occurred in a project I was upgrading to the newest version of the Spring Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /