-
Notifications
You must be signed in to change notification settings - Fork 310
DATACASS-169: Deal with breaking changes introduced in cassandra-driver-dse 2.1.0 & later #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this dependency because it's not used by the code as far as I can tell and the project itself is abandoned.
Maybe this can be moved to a separate PR, lemme know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the dependency refactoring into a separate ticket.
Amazing! The driver update is on our roadmap for the next release. Thanks for your PR, I'll take a look in the next days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's shift the dependency refactoring to a separate issue.
@atoulme Pretty decent work. I reviewed your PR and added some minor comments.
0e1783d to
4666be8
Compare
@mp911de Feedback addressed, I amended the commit. I'll rerun the tests now.
4666be8 to
7e9d33a
Compare
Here is the result of the tests:
Failed tests:
AsynchronousTest.testString_QueryForListListener:353->assertMapEquals:72 expected:<[bc991327-c5c2-493f-bcbc-97dc36e83c6d]> but was:<[3e02696d-a8eb-4a4a-85c6-798e4dbce895]>
Tests run: 76, Failures: 1, Errors: 0, Skipped: 0
If I run AsynchronousTest by itself, all tests pass.
...er-dse 2.1.0 & later This commit adds support for Cassandra 3.x with the latest Datastax Driver 3.0.0. This migration follows the guidelines listed at https://datastax.github.io/java-driver/upgrade_guide/.
7e9d33a to
4fafbec
Compare
Thanks for the fast response. AsynchronousTest is known to fail once in a while, don't worry.
I take your PR from here and add some polishing to it. Our plan is to keep the 3.0 changes on a feature branch until we release the first milestone.
@mp911de no problem. On a sidebar... What else do you need to make the release happen? Is there a roadmap on jira?
We're releasing usually Spring Data as release trains meaning all modules are released on the same day. We release GA versions about twice a year. Recently we released Hopper, next is Ingalls.
We publish our release schedule in the Spring Data Commons Wiki.
This commit adds support for Cassandra 3.x with upgrading to Datastax Driver 3.0.0. Data type deserialization is performed using the CodecRegistry. Original pull request: spring-projects#52. Related ticket: DATACASS-169.
Add author tags. Add/update license headers where needed. Remove calls to deprecated methods. Adopt pooling options after the driver update. Add hints_directory for Cassandra 3. Reduce driver baseline to core driver 3.0.1. The DSE driver requires the core driver itself and can be added as dependency to user projects while retaining full compatibility. As of now the DSE driver is rc1 hence it requires core rc1. Use getTimestamp for timestamp type methods as the driver aligned the method to the type. Support short, byte and time. Enable LocalDate return type and add tests for native supported types. Change long to bigint type as long was mapped to the counter type when creating tables. Align the default to bigint as bigint is the better choice since table creation uses mostly regular tables and not counter tables. Type can be overriden using @CassandraType. We now support setting NettyOptions on CassandraCqlClusterFactoryBean and AbstractClusterConfiguration. The cassandra driver 2.1.9 changed its default shutdown behavior by introducing a 2 second quiet period when shutting down Cluster instances. This change was retained throughout the 3.0 driver which slow the test down by an order of magnitude. Configure QueryOptions on tests to prevent delays caused by the asynchronous schema refresh. Original pull request: spring-projects#56. Related pull request: spring-projects#52. Related ticket: DATACASS-169.
This commit adds support for Cassandra 3.x with the latest Datastax Driver 3.0.0. This migration follows the guidelines listed at https://datastax.github.io/java-driver/upgrade_guide/.
Submitted ICLA.
Feedback is very welcome.