Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Allow QueryOptions to disable timeout #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@seungh0
Copy link
Contributor

@seungh0 seungh0 commented Jun 12, 2024 •
edited
Loading

Allow QueryOptions to set timeout to 0.

If it is zero, the read timeout will be disabled for this statement

Closes #1494

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
 

If it is zero, the read timeout will be disabled for this statement.
Closes spring-projects#1494
@seungh0 seungh0 force-pushed the GH-1494-allow-zero-timeout branch from 19a72fa to de11972 Compare June 12, 2024 10:29
@seungh0 seungh0 changed the title (削除) Allow QueryOptions to set timeout to 0. (削除ここまで) (追記) Allow QueryOptions to set timeout to 0 (追記ここまで) Jun 12, 2024
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 12, 2024
@mp911de mp911de changed the title (削除) Allow QueryOptions to set timeout to 0 (削除ここまで) (追記) Allow QueryOptions to disable timeout (追記ここまで) Jun 12, 2024
mp911de pushed a commit that referenced this pull request Jun 12, 2024 
If it is zero, the read timeout will be disabled for this statement.
Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.
See #1494
Original pull request: #1495
mp911de pushed a commit that referenced this pull request Jun 12, 2024 
If it is zero, the read timeout will be disabled for this statement.
Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.
See #1494
Original pull request: #1495
mp911de pushed a commit that referenced this pull request Jun 12, 2024 
If it is zero, the read timeout will be disabled for this statement.
Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.
See #1494
Original pull request: #1495
Copy link
Member

mp911de commented Jun 12, 2024

Thank you for your contribution. That's merged, polished, and backported now.
seungh0 reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion does not match its error message and comments for QueryOptions.readTimeout method

AltStyle によって変換されたページ (->オリジナル) /