-
Notifications
You must be signed in to change notification settings - Fork 311
DATACASS-555 - minor fix to CqlTemplate #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Created separate PR for this when saw the build failing.
Running mvn clean test locally works, but that is b/c my Cassandra version is 3.11.2.
The local time tests, when Cassandra version is 2.2.10, are failing in CassandraTypeMappingIntegrationTests on Travis CI
A quick look and can't see why these changes would impact this
operations.insert(entity);
Seems related to this
https://gist.github.com/mp911de/b61a1a24bd824d0742a6b2e31ecb4861
As the error is
nested exception is com.datastax.driver.core.exceptions.InvalidQueryException: Invalid INTEGER constant (3723000) for "localtime" of type time
any thoughts?
This issue was fixed in Cassandra 3.0.8 and 3.8 with CASSANDRA-11798. We require symmetric data types and the problem with time was that reading-wise it returned a number whereas updating required a string literal. time is only supported on Cassandra versions 3.0.8/3.8 and higher.
We will remove the failing build profile from the Travis CI build to omit confusion.
See also:
I filed DATACASS-563 to address the failing tests with Cassandra 2.2.
...on of PreparedStatementCreator. Original pull request: #133.
Add Javadoc. Tweak Javadoc for consistency. Refactor SimpleReactivePreparedStatementCreator into newReactivePreparedStatementCreator(...) method. Reformat code. Original pull request: #133.
...on of PreparedStatementCreator. Original pull request: #133.
Add Javadoc. Tweak Javadoc for consistency. Refactor SimpleReactivePreparedStatementCreator into newReactivePreparedStatementCreator(...) method. Reformat code. Original pull request: #133.
Thanks a lot. That's merged, polished, and backported now.
Allow for caching the prepared statements in the CqlTemplate if a PreparedStatementCache implementation is provided
https://jira.spring.io/browse/DATACASS-555