-
Notifications
You must be signed in to change notification settings - Fork 784
Updating Zipkin settings in readme #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pivotal-issuemaster
commented
Sep 25, 2019
@kubamarchwicki Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@pivotal-issuemaster This is an Obvious Fix
pivotal-issuemaster
commented
Sep 25, 2019
@kubamarchwicki Thank you for signing the Contributor License Agreement!
Codecov Report
Merging #1451 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #1451 +/- ## ========================================= Coverage 58.01% 58.01% Complexity 800 800 ========================================= Files 151 151 Lines 4290 4290 Branches 465 465 ========================================= Hits 2489 2489 Misses 1587 1587 Partials 214 214
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 38ffcbc...32ccf10. Read the comment docs.
Correcting properties name to reflect the code: https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/sampler/SamplerProperties.java#L36