-
Couldn't load subscription status.
- Fork 784
Also mention the net.devh:grpc-spring-boot-starter library #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also mention the net.devh:grpc-spring-boot-starter library #1213
Conversation
pivotal-issuemaster
commented
Feb 16, 2019
@ST-DDT Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
pivotal-issuemaster
commented
Feb 16, 2019
@ST-DDT Thank you for signing the Contributor License Agreement!
Which does sleuth integrate with in this repository?
This library contains support classes for the lognet library. See TraceGrpcAutoConfiguration
and some other support classes that are needed because they are not present in that library.
yidongnan/grpc-spring-boot-starter supports this library out of the box: See TraceClientAutoConfiguration . No further support classes are needed. If you want, we could move the sleuth related client + server configuration here as well.
See also:
- First attempt to add GRPC instrumentation #1139 (especially the later comments)
- 415a7a6#r32244784
- Provide gRPC support [SPR-16358] spring-projects/spring-framework#20905
We don't really document external projects. We may link to it, but not document it
Changed the PR to only contain the link.
PS: Why is the build failing? I only changed the docs.
Currently you mention only one library for grpc spring-boot support, but there are currently two main libraries.
LogNet/grpc-spring-boot-starter only supports the server side, whereas yidongnan/grpc-spring-boot-starter supports the server and client side, as well as Spring-Security and other features.
Please also mention the second library.
Disclosure: I'm one of the core maintainers of yidongnan/grpc-spring-boot-starter.