Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typo in docs #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcingrzejszczak merged 4 commits into spring-cloud:master from ackintosh:fix-typo
Dec 15, 2018
Merged

Fix typo in docs #1157

marcingrzejszczak merged 4 commits into spring-cloud:master from ackintosh:fix-typo
Dec 15, 2018

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 12, 2018
edited
Loading

Obvious Fix

Copy link

@ackintosh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link

@ackintosh This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

Copy link

codecov-io commented Dec 12, 2018
edited
Loading

Codecov Report

Merging #1157 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #1157 +/- ##
============================================
- Coverage 69.74% 69.62% -0.12% 
 Complexity 724 724 
============================================
 Files 133 133 
 Lines 3368 3368 
 Branches 364 364 
============================================
- Hits 2349 2345 -4 
- Misses 811 816 +5 
+ Partials 208 207 -1
Impacted Files Coverage Δ Complexity Δ
...ing/TracingConnectionFactoryBeanPostProcessor.java 69.64% <0%> (-3.58%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c426a...4444cd7. Read the comment docs.

Copy link
Contributor

@devinsba devinsba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have merge power so I can't merge it.

Thanks for the fixes though!

Copy link
Contributor

Can you fix it in the docs module, not the root README.

Copy link
Contributor Author

Thanks for pointing it out. I'll fix it.

Copy link
Contributor Author

@marcingrzejszczak I've fixed it. Please have a look when you have time. 😌

Copy link
Contributor

Congrats @ackintosh on your first contribution!!

Copy link
Contributor Author

Wow! You made my day. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devinsba devinsba devinsba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.1.0.RC3

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /