Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Adds Byond detection support #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaronskaya merged 1 commit into sourcerer-io:develop from CorruptComputer:byond
Jan 9, 2020
Merged

feat: Adds Byond detection support #562

yaronskaya merged 1 commit into sourcerer-io:develop from CorruptComputer:byond
Jan 9, 2020

Conversation

@CorruptComputer
Copy link
Contributor

@CorruptComputer CorruptComputer commented Dec 5, 2019

I finally got around to this, but this is to support this PR: sourcerer-io/awesome-libraries#104

Please let me know if any changes are needed!

Copy link
Contributor

Hi @CorruptComputer. Thank you for adding that.
Is Byond a part of DM language? Github classify it as DM language now.
What is a way to import libraries in code in that language?

Copy link
Contributor Author

Hi @yaronskaya DM is the custom language Byond created for their game engine. I don't believe that libraries are able to be imported, as all of the code written must be attached to an object in the game world.

Copy link
Contributor

@CorruptComputer Would it be more correct to assign DM as language of a code?
Regarding the libraries, what are these items that you provided in awesome-libraries PR? Are these libraries or not?

I'm asking because we need to clarify the language specifics before reviewing PRs.

Copy link
Contributor Author

Possibly? Those are the different kinds of files you can have in the project, for example .dm is for the code. .dmm is for the mapping, and .dmi is for the sprites you create within the editor.

The only reason I lumped them all into Byond is that none of the code can be used outside of this engine.

Copy link
Contributor

@CorruptComputer got it.

  1. Let's assign .dm, .dmi, .dmm to DM language in Heuristics.kt
  2. Let's assign .dmi, .dmm to Byond technology. See example where we assigned all .vue files to Vue technology in javascript. Basically, you will need to create DMExtractor and override extractLibStats function.
  3. I'll add the combining of DM files and Byond technology to Byond on our backend so that when a repo has Byond technology and .dm files then .dm will be threated as Byond.

Does that work for you?

Copy link
Contributor Author

That works for me 👍

I'll start working on that now.

Copy link
Contributor Author

I believe I have made the requested changes, I'm not very familiar with Kotlin and this is actually my first time working with it. Please tell me if anything else needs changes!

Copy link
Contributor

@yaronskaya yaronskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CorruptComputer looks good!
Requested minor changes. I'm ready to merge it as soon as you fix it.

Copy link
Contributor Author

@yaronskaya I've made the requested changes, are there any changes needing to be made to sourcerer-io/awesome-libraries#104?

Copy link
Contributor

@yaronskaya yaronskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CorruptComputer lgtm, thank you for doing that.
Also, reviewed your pr in awesome-libraries.

@yaronskaya yaronskaya merged commit 2e602e6 into sourcerer-io:develop Jan 9, 2020
yaronskaya added a commit that referenced this pull request Jan 9, 2020
feat: add DM and Byond detection support (#562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaronskaya yaronskaya yaronskaya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /