-
Couldn't load subscription status.
- Fork 275
feat: Adds Byond detection support #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @CorruptComputer. Thank you for adding that.
Is Byond a part of DM language? Github classify it as DM language now.
What is a way to import libraries in code in that language?
Hi @yaronskaya DM is the custom language Byond created for their game engine. I don't believe that libraries are able to be imported, as all of the code written must be attached to an object in the game world.
@CorruptComputer Would it be more correct to assign DM as language of a code?
Regarding the libraries, what are these items that you provided in awesome-libraries PR? Are these libraries or not?
I'm asking because we need to clarify the language specifics before reviewing PRs.
Possibly? Those are the different kinds of files you can have in the project, for example .dm is for the code. .dmm is for the mapping, and .dmi is for the sprites you create within the editor.
The only reason I lumped them all into Byond is that none of the code can be used outside of this engine.
@CorruptComputer got it.
- Let's assign .dm, .dmi, .dmm to DM language in Heuristics.kt
- Let's assign .dmi, .dmm to Byond technology. See example where we assigned all .vue files to Vue technology in javascript. Basically, you will need to create DMExtractor and override extractLibStats function.
- I'll add the combining of DM files and Byond technology to Byond on our backend so that when a repo has Byond technology and .dm files then .dm will be threated as Byond.
Does that work for you?
That works for me 👍
I'll start working on that now.
I believe I have made the requested changes, I'm not very familiar with Kotlin and this is actually my first time working with it. Please tell me if anything else needs changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CorruptComputer looks good!
Requested minor changes. I'm ready to merge it as soon as you fix it.
@yaronskaya I've made the requested changes, are there any changes needing to be made to sourcerer-io/awesome-libraries#104?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CorruptComputer lgtm, thank you for doing that.
Also, reviewed your pr in awesome-libraries.
feat: add DM and Byond detection support (#562)
I finally got around to this, but this is to support this PR: sourcerer-io/awesome-libraries#104
Please let me know if any changes are needed!