Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add :tbd group for Black Dog samples #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samaaron merged 4 commits into sonic-pi-net:dev from rbnpi:dev
Jun 9, 2025
Merged

Add :tbd group for Black Dog samples #3461

samaaron merged 4 commits into sonic-pi-net:dev from rbnpi:dev
Jun 9, 2025

Conversation

@rbnpi
Copy link
Contributor

@rbnpi rbnpi commented Jun 7, 2025

Correct ReadMe typo
Add :tbd group for Black Dog samples

Copy link
Contributor Author

rbnpi commented Jun 8, 2025

happy for both these changes. is the easiest way to implement to delete the pr and resubmit it with the alterations proposed?

Copy link
Collaborator

ethancrawford commented Jun 8, 2025
edited
Loading

@rbnpi you should hopefully have a button under each suggested change to add them as new commits directly, or add them to a batch as a single commit? (Although I'm not entirely sure about how that works, maybe it applies to multiple suggestions per user? Don't know...) Either way is probably good 🤷🙂

rbnpi and others added 2 commits June 8, 2025 17:40
Co-authored-by: Emlyn Corrin <emlyn.corrin@gmail.com>
Co-authored-by: ethancrawford <ethan_jc@hotmail.com>
@samaaron samaaron merged commit 4520ebf into sonic-pi-net:dev Jun 9, 2025
10 checks passed
Copy link
Collaborator

samaaron commented Jun 9, 2025

Oops - I had written this but somehow failed to commit it. Thanks for filling the gap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethancrawford ethancrawford ethancrawford left review comments

+1 more reviewer

@emlyn emlyn emlyn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /