Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

createForm proposal #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tanner-Scadden wants to merge 4 commits into solidjs-community:main
base: main
Choose a base branch
Loading
from Tanner-Scadden:form/proposal

Conversation

@Tanner-Scadden
Copy link
Contributor

@Tanner-Scadden Tanner-Scadden commented Feb 15, 2023

  • exports a createForm primitive
  • Uses lodash.set to handle nested sets
  • Uses zod to do schema validations
  • Returns a handleSubmit function to put onto a form
  • returns data gathered in the form. Converts number values to numbers for ease of use.
  • If there is an error from the validation, returns the zod errors & form data for debugging.

Murzbul and leegee reacted with thumbs up emoji
Copy link

changeset-bot bot commented Feb 15, 2023
edited
Loading

⚠️ No Changeset found

Latest commit: b78a704

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Tanner-Scadden Tanner-Scadden changed the title (削除) Form/proposal (削除ここまで) (追記) createForm proposal (追記ここまで) Feb 15, 2023
Copy link
Contributor Author

@thetarnav Let me know what else needs to be done for this proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /