Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Example/static components #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AceMouty wants to merge 5 commits into solidjs-community:main
base: main
Choose a base branch
Loading
from AceMouty:example/static-components

Conversation

@AceMouty
Copy link
Contributor

@AceMouty AceMouty commented Jun 22, 2022

A demo showing a simple site built with (non stateful) components using SolidJS

Features:

  • CSS modules
  • Solid components (non stateful)
  • Global stying and custom props in src/index.css

static-components-result

OkelleyDevelopment and thetarnav reacted with rocket emoji
@@ -0,0 +1,109 @@
/*
{{
Copy link

@milomg milomg Jun 22, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { Navbar } from './components/Navbar';
import { Title } from './components/Title';

const App: Component = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that one common style should be used for Components, I think that export default function FunctionName is also used in the tutorial on site. So export default function App here?

import logo from '../../logo.svg';
import { SocialList } from '../SocialList';

export default function () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a name to the function here, for consistency sake?

Copy link
Collaborator

Mind resolving the merge conflict please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@high1 high1 high1 left review comments

@milomg milomg milomg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /