-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add WorkletRuntime::executeAsync
#8425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukmccall
wants to merge
1
commit into
software-mansion:main
from
lukmccall:@lukmccall/add-execute-async
Open
feat: Add WorkletRuntime::executeAsync
#8425
lukmccall
wants to merge
1
commit into
software-mansion:main
from
lukmccall:@lukmccall/add-execute-async
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new method to the
WorkletRuntimecalledexecuteAsync. This method schedules a new job (std::function) on the thread connected with the runtime. Currently, the only available function allows us to schedule a worklet, which doesn't fit my use case.Test plan
expo/expo✅