-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update messageStore.js to fix Issue:It it duplicating the self messag... #5341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MeeeeetShah
wants to merge
1
commit into
socketio:examples/private-messaging-part-4
from
MeeeeetShah:examples/private-messaging-part-4
Open
Update messageStore.js to fix Issue:It it duplicating the self messag... #5341
MeeeeetShah
wants to merge
1
commit into
socketio:examples/private-messaging-part-4
from
MeeeeetShah:examples/private-messaging-part-4
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...es after refreshing the window in examples/private messages socketio#5340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...es after refreshing the window in examples/private messages #5340
The kind of change this PR does introduce
Current behavior
It's duplicate the message in redis store for self messages due to no condition checks
New behavior
It resolved by just adding a simple condition
Other information (e.g. related issues)