Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use bash parameter expansion. #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Montana wants to merge 2 commits into smallstep:master
base: master
Choose a base branch
Loading
from Montana:patch-1
Open

Conversation

@Montana
Copy link

@Montana Montana commented Feb 8, 2024

I've updated this so it cleverly uses bash parameter expansion to conditionally include the current word and a space only if it starts with a hyphen.

I've updated this so it cleverly uses bash parameter expansion to conditionally include the current word and a space only if it starts with a hyphen.
Copy link

CLAassistant commented Feb 8, 2024
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dopey
❌ Montana
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Feb 8, 2024
Copy link
Contributor

dopey commented Apr 23, 2024

Hey @Montana 👋. Thanks for submitting the PR! I'm really sorry it's taken so long for me to get around to testing :[

That said, I have tested on my local and I'm not sure it's working as intended. When I type step ca provisioner (no space at the end) and then hit <tab><tab> I get garbled output. I'm just using step ca provisioner as an example here, because this happens with any command.

If I try the same thing with the existing bash_completion script I get the intended output (listing the currently available commands - in this case just provisioner, since I haven't completed that word).

Let me know if I'm doing something wrong. As my username reflects, I can be pretty thick skulled at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /