-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: respect the configured receive window #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the count should be less than the configured receive window, not the default receive window
hey @skywind3000 can you confirm that this is a bug?
we are using kcp for Mirror Networking in Unity.
this bug seems to limit max message size for no obvious reason.
... windows/messages than defaults for skywind3000/kcp#291
... windows/messages than defaults for skywind3000/kcp#291
...based on receive window size. #22 skywind3000/kcp#291
...based on receive window size. #22 skywind3000/kcp#291
we have a applied this fix for C# kcp version.
it works well.
我们在 C# 版本中修复了它。它工作正常。
- uncorks max message size from 144 KB to as much as we want based on receive window size. fixes MirrorNetworking/kcp2k#22 fixes skywind3000/kcp#291 - feature: OnData now includes channel it was received on - fixes #2989
这里应该是 if (count >= 256) return -2; 才对吧,frg字段只有一个字节。
这里应该是 if (count >= 256) return -2; 才对吧,frg字段只有一个字节。
Thank you. We noticed this too just now.
谢谢你。我们刚才也注意到了这一点。
murshex
commented
Oct 24, 2022
@skywind3000 This is your project which is supposed to be a replacement for TCP (Most used protocol in the world). Why have you not merged this pull request yet.
the count should be less than the configured receive window, not the default receive window