Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[ENH] Add warning for multi-target forecasting support in BaseModel #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PranavBhatP wants to merge 6 commits into sktime:main
base: main
Choose a base branch
Loading
from PranavBhatP:missing-warning-multi-target

Conversation

@PranavBhatP
Copy link
Contributor

@PranavBhatP PranavBhatP commented Jun 9, 2025

Reference Issues/PRs

fixes #1879.

What does this implement/fix? Explain your changes.

Additional warning for missing multi-target support.

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@33041c7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/base/_base_model_v2.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## main #1880 +/- ##
=======================================
 Coverage ? 85.95% 
=======================================
 Files ? 89 
 Lines ? 7595 
 Branches ? 0 
=======================================
 Hits ? 6528 
 Misses ? 1067 
 Partials ? 0
Flag Coverage Δ
cpu 85.95% <66.66%> (?)
pytest 85.95% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@fkiraly fkiraly changed the title (削除) [ENH] Add warning for multi-target forecasting support IN BaseModel (削除ここまで) (追記) [ENH] Add warning for multi-target forecasting support in BaseModel (追記ここまで) Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa fnhirwa is a code owner

@jdb78 jdb78 Awaiting requested review from jdb78 jdb78 is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

@fkiraly fkiraly Awaiting requested review from fkiraly fkiraly is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENH] add warnings to indicate missing multi-target forecasting support with MultiLoss in v2 base model.

AltStyle によって変換されたページ (->オリジナル) /