-
Notifications
You must be signed in to change notification settings - Fork 17
Update for phpcs 4.0.0 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few notes.
19c4bf4 to
02d3d7f
Compare
e0d6ace to
b4d100d
Compare
Nearly got this working. There's just coverage failures now: ERROR: Couldn't find specified file: build/logs/clover.xml. I'm guessing that the API of some coverage thing has changed.
Nearly got this working. There's just coverage failures now:
ERROR: Couldn't find specified file: build/logs/clover.xml. I'm guessing that the API of some coverage thing has changed.
No, you added PHPUnit 12 to the composer.json without accounting for it in the workflow....
No, you added PHPUnit 12 to the composer.json without accounting for it in the workflow....
🤦 Oops! I just updated all the dependencies without looking too closely at major versions. Thank you!
f612edd to
067e988
Compare
Uh oh!
There was an error while loading. Please reload this page.
Fixes #355
This PR follows the upgrade guide in https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-Developer-Upgrade-Guide
The main change is supporting the
T_NAME...constants likeT_NAME_FULLY_QUALIFIEDin function names.