-
Notifications
You must be signed in to change notification settings - Fork 17
Switch to PHPCSStandards/PHP_CodeSniffer #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation. Ref: * squizlabs/PHP_CodeSniffer 3932
@jrfnl
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
December 7, 2023 03:14
2af5149 to
9c393d3
Compare
Update: The Composer package name will not change, so while this PR should still be merged at your convenience, no new release is needed to unblock end-users, nor does the minimum supported PHPCS version need to change.
sirbrillig
sirbrillig
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for your efforts!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
(削除) (which contains the Composer, this can/should be mergedreplacedirective) (削除ここまで)(削除) and released ASAP (削除ここまで).Switch to PHPCSStandards/PHP_CodeSniffer
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.
(削除) Includes updating the dev required version of the Composer plugin, which should make sure that this repo already switches over to using the PHPCSStandards version of PHPCS. (削除ここまで)Ref:
Closes #314
(削除) [OPTIONAL] Composer: raise the minimum supported PHPCS version to 3.8.0 (削除ここまで)(削除) ... to prevent end-users from running into trouble with the name change. (削除ここまで)(削除) The files in the Composervendor/binwill only be replaced when thereplace...directive is found and that is only available in the 3.8.0 tag. (削除ここまで)(削除) When the files in the Composervendor/binare not replaced, they will continue to point to thevendor/squizlabs/php_codesnifferdirectory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF. (削除ここまで)(削除) Includes updating references to the PHPCS version whenever relevant throughout the codebase. (削除ここまで)(削除) Note: it should work fine without this change, but may lead to support requests. (削除ここまで)(削除) Composer: update various version constraints (削除ここまで)(削除) ... after the tooling has also updated to the PHPCSStandards version of PHPCS. (削除ここまで)(削除) Refs: (削除ここまで)(削除) * https://github.com/PHPCSStandards/PHPCSDevCS/releases (削除ここまで)