-
-
Couldn't load subscription status.
- Fork 32
fix: support parsing */ expressions without surrounding spaces #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(削除) If . Context checked with calc() context cannot be determined, I think a partial fix that handles * without surrounding spaces still suffices a PR (削除ここまで)this.lastNode.type === 'func'
@cyjake
cyjake
force-pushed
the
fix-138
branch
from
November 23, 2021 23:49
04ad8f7 to
46a210d
Compare
@cyjake
cyjake
changed the title
(削除) [wip] fix: support parsing */ expressions without surrounding spaces (削除ここまで)
(追記) fix: support parsing */ expressions without surrounding spaces (追記ここまで)
Nov 23, 2021
@shellscape pr is ready now :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #138
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
The tokens returned by postcss does not split chunk like
*var, which causes expressions that containing*or/operations without surrounding spaces to break. This PR checks the value before letting them go throughFunc, and tokenize further withOperatorinstead, therefore fixes the issue./is tricky to determine becauseurl(/foo/bar.jpg)is totally legit as well. Is there any means that can be used to determine current context is truly an expression incalc()?