Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: Quoted – clone throw an error (#141) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellscape merged 1 commit into shellscape:master from marcalexiei:bugfix-quoted-clone
Jan 7, 2022
Merged

fix: Quoted – clone throw an error (#141) #142

shellscape merged 1 commit into shellscape:master from marcalexiei:bugfix-quoted-clone
Jan 7, 2022

Conversation

@marcalexiei
Copy link
Contributor

@marcalexiei marcalexiei commented Nov 17, 2021 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Please Describe Your Changes

  • add integration check before set Quoted properties. This avoid an error while cloning node since clone function calls the constructor without any parameter (fixes Unable to clone value with quotes characters #141 )
  • add missing quoted.test.js file (fixtures were already present)
  • add test of clone for Quoted inside quoted.test.js

webistomin reacted with heart emoji 
- add missing `quoted.test.js` file (fixtures were already present)
Copy link
Contributor Author

@shellscape, any chance to merge, and possibly release, this change?
Thanks in advance 🙏
monospaced, tomasklaen, and webistomin reacted with thumbs up emoji

@shellscape shellscape merged commit a59fac9 into shellscape:master Jan 7, 2022
@marcalexiei marcalexiei deleted the bugfix-quoted-clone branch January 7, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shellscape shellscape shellscape approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to clone value with quotes characters

AltStyle によって変換されたページ (->オリジナル) /