-
-
Notifications
You must be signed in to change notification settings - Fork 32
Add hwb, lab, and lch to functions matching isColor #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hwb, lab, and lch to functions matching isColor #111
Conversation
Thanks! I'll get this merged and released tonight
Sweet! I’ll follow along. 👍 Thanks a ton!
Sorry for not getting this published last night. Came down with something and just woke up a bit ago. Looks like I just needed sleep. I have a few tweaks I want to make and then I'll get a new version out.
Note: I would expect the isColor and isVar helper properties to be getters, so that in the event one reassigns a function name, they remain accurate. I am open to adding that in a separate PR if you feel it will add value.
I'm open to that.
This PR contains:
Breaking Changes?
This PR changes the way the
isColorproperty of aFuncis determined so that it may includehwb(),lch(), andlab()notations.Note: This is not causing me any issues in my current work. It’s just something I noticed while inspecting the code.
Note: I would expect the
isColorandisVarhelper properties to be getters, so that in the event one reassigns a function name, they remain accurate. I am open to adding that in a separate PR if you feel it will add value.