Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a few feature with will make component more flexible #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ImmortalJoker wants to merge 11 commits into shallinta:master from ImmortalJoker:master
Closed

Add a few feature with will make component more flexible #6

ImmortalJoker wants to merge 11 commits into shallinta:master from ImmortalJoker:master

Conversation

@ImmortalJoker
Copy link

@ImmortalJoker ImmortalJoker commented Aug 29, 2018

No description provided.

Copy link
Owner

Well. There is a few features in this one PR, and I didn't see any descriptions about these fetures. And I saw a great modification to origin code.
This is hard for me to review your code and fetures.

Could you please split your ideas into different PR and add some description in each PR?
If this tortured you a lot, you can just raise one issue for each feature you want.

Looking forward to see some new PRs or good issures.

Copy link
Author

ImmortalJoker commented Sep 13, 2018 via email

Hello, I did description on Readme, right after your features. Please read. I'll try to split it, when I'll have time Chears. чт, 13 сент. 2018 г. в 9:07, 陈展 <notifications@github.com>:
...
Closed #6 <#6>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD191rL0-S0FXcBSC5dRYwhnhAIE7d4mks5uafYugaJpZM4WRZAt> .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /